Skip to content

Conversation

@Jean85
Copy link
Member

@Jean85 Jean85 commented Aug 15, 2025

Tries to fix #326
Adds CI job to test under PHP 8.5

@Jean85 Jean85 self-assigned this Aug 15, 2025
@Jean85
Copy link
Member Author

Jean85 commented Aug 15, 2025

@keradus as you can see, my CI is green even under PHP 8.5: https://github.com/facile-it/paraunit/actions/runs/16993356550/job/48177975461?pr=327

So, I cannot reproduce any issue here, and I do not see any issue specific of Paraunit in your failed test run here: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/actions/runs/16950052409/job/48040517434

Let me know if you're able to restrict the issue to a small reproducer.

@keradus
Copy link

keradus commented Aug 15, 2025

i failed to identify smaller reprocase other than PHPUnit passing on CI and ParaUnit failing on CI under 8.5. both passing under older PHP.
if you up for it, feel welcome to experiment directly in our repo CI via kind-of-debugging PR.

if you not up for it, totally ok. i will keep paraunit disabled till root cause found

@Jean85
Copy link
Member Author

Jean85 commented Aug 16, 2025

Thanks to #328 it's now failing due to some deprecation inside Composer's vendor folder:

PHP Deprecated:  Case statements followed by a semicolon (;) are deprecated, use a colon (:) instead in phar:///usr/local/bin/composer/vendor/react/promise/src/functions.php on line 300

So it doesn't seem to have unearthed the real issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems under PHP 8.5

3 participants