fix: Use primary-navigation as aria-label when it is primary navigation
#1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
sergiocarracedo
approved these changes
Mar 7, 2025
Contributor
|
Those names must be translated |
nlopin
reviewed
Apr 15, 2025
| secondary={secondary} | ||
| asChild | ||
| aria-label={secondary ? "primary-navigation" : "secondary-navigation"} | ||
| aria-label={secondary ? "secondary-navigation" : "primary-navigation"} |
Contributor
There was a problem hiding this comment.
Let's then update the language file and request proper translations for the labels
Collaborator
|
Does this PR makes sense now? If not, could you close it? if yes, can we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have asked Claude for a Haiku to celebrate my first PR in Factorial one
Type of Change