Skip to content

Conversation

@ccebrecos
Copy link
Contributor

@ccebrecos ccebrecos commented Jul 9, 2025

Description

Add new Eq filter, that only allow selecting one option.

Screenshots (if applicable)

image image

Implementation details

Added new filter, reused and shared the logic under useLoadOptions.ts

@ccebrecos ccebrecos self-assigned this Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

🔍 Visual review for your branch is published 🔍

Here are the links to:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to copy the packages/react/src/experimental/OneDataCollection/Filters/FilterTypes/InFilter/useLoadOptions.ts file instad of use it?

The InFilter and the Eq filters are basically the same, the main diffrence is the amout of items to select and the ui when is multiselection (checkboxes) or single selection.

I think we could use the selectList component we are working on for this filter to dont need to repeat the code and to allow event to use datasources for the filters options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asked cursor to create the filter as an exercise (of having a draft of the filter and use cursor itself to create something) and I'm still evaluating the result. It's missing my own revision of the code to see what can I take profit of and what should be removed / improved. That's why is still in draft 👀

The InFilter and the Eq filters are basically the same
And yes, I do completely agree on that.

Let's evaluate then the usage of the selectList component.

Thanks for the insights! 🙏🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code to reuse the useLoadOptions.ts logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants