feat(DataCollection): add list navigation filter #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
Contributor
Contributor
size-limit report 📦
|
rubenmoya
force-pushed
the
add-navigation-list
branch
from
02766ea to
d41245b
Compare
rubenmoya
force-pushed
the
add-navigation-list
branch
from
dd1bc54 to
0d1bf5d
Compare
rubenmoya
force-pushed
the
add-navigation-list
branch
from
00a31cb to
614c29d
Compare
rubenmoya
commented
Oct 28, 2025
Contributor
Author
There was a problem hiding this comment.
This file was duplicated, we had a .ts one and a .tsx one. I've kept the one with the most recent changes.
sergiocarracedo
approved these changes
Nov 3, 2025
Collaborator
|
Does this PR makes sense now? If not, could you close it? if yes can you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Engagement, we need a new navigation filter to move through the different cycles for each survey.
Keep in mind, that even if you see dates there, we're not selecting date ranges from a calendar by a given granularity like we do in the date navigation. In this case is a list of cycles, and the granularity could be different, or non-existen if the survey is sent manually.
More information in this slack thread
Screenshots (if applicable)
Closed:
Open:
With different list:
Use in the DataCollection:
Implementation details
This PR implements a new
F0ListNavigationcomponent that allows users to navigate through a given list using arrows. This component is not exported, right now it's only used internally for theDataCollection.