feat: introduce alwaysOpen prop in F0Select for inline selection lists #3131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
Contributor
size-limit report 📦
|
Contributor
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 157 |
sergiocarracedo
requested changes
Dec 16, 2025
| /** | ||
| * Height of the list container when alwaysOpen is true. | ||
| */ | ||
| alwaysOpenHeight?: "sm" | "md" | "lg" |
Collaborator
There was a problem hiding this comment.
Why we limit the height in the component? The component should use the max height and the parent should be the one that set the height limit
| * The component renders only the content area (options list) without the input field. | ||
| * Useful for inline selection lists or embedded selectors. | ||
| */ | ||
| alwaysOpen?: boolean |
Collaborator
There was a problem hiding this comment.
Why not asList?. For me alwaysOpen, means the popover is always open, but we will not use a popover
| filters, | ||
| currentFilters, | ||
| onFiltersChange, | ||
| autoFocus = true, |
Collaborator
There was a problem hiding this comment.
I think autofocus only should be true by defait in the "popover" mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots (if applicable)
[Link to Figma Design](Figma URL here)
Implementation details