Skip to content

Conversation

@siguenzaraul
Copy link
Contributor

Description

This PR fixes a bug in the F0Dialog component where left and right aligned versions would overflow their content. It also removes an incorrect top border that was appearing

Screenshots (if applicable)

Captura de pantalla 2026-01-08 a las 17 08 19 Captura de pantalla 2026-01-08 a las 17 10 39

[Link to Figma Design](Figma URL here)

Implementation details

@siguenzaraul siguenzaraul requested a review from a team as a code owner January 8, 2026 16:15
@github-actions github-actions bot added fix react Changes affect packages/react labels Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

✅ No New Circular Dependencies

No new circular dependencies detected. Current count: 0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

📦 Alpha Package Version Published

Use pnpm i github:factorialco/f0#npm/alpha-pr-3203 to install the package

Use pnpm i github:factorialco/f0#59470359bb01702f51f493ce4ed2ad6c2be9c566 to install this specific commit

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Coverage Report for packages/react

Status Category Percentage Covered / Total
🔵 Lines 37.46% 5772 / 15408
🔵 Statements 36.88% 5893 / 15976
🔵 Functions 26.55% 1224 / 4609
🔵 Branches 27.15% 3293 / 12127
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/F0Dialog/F0DialogInternal.tsx 9.37% 0% 0% 9.37% 85-193
packages/react/src/ui/Dialog/components/DialogContent.tsx 20% 0% 0% 22.22% 29-65
Generated in workflow #10109 for commit ec62fa9 by the Vitest Coverage Report Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

🔍 Visual review for your branch is published 🔍

Here are the links to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix react Changes affect packages/react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants