-
Notifications
You must be signed in to change notification settings - Fork 3
chore/test bugbot #3210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore/test bugbot #3210
Conversation
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 0 |
📦 Alpha Package Version PublishedUse Use |
| ) | ||
| }) | ||
|
|
||
| OneTestComponent.displayName = "OneTestComponent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New component not exported in exports.ts (Bugbot Rules)
Medium Severity
The OneTestComponent is added to the components folder but is not exported in components/exports.ts. This violates the BUGBOT.md rule: "Ensure a component in components or experimental is exported in exports.ts". The component will not be accessible to consumers of the package.
| ) | ||
| }) | ||
|
|
||
| OneTestComponent.displayName = "OneTestComponent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| children?: ReactNode | ||
| className?: string | ||
| variant?: "default" | "outlined" | "filled" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component exposes className as public prop (Bugbot Rules)
Low Severity
The OneTestComponentProps interface exposes className as a public prop. This violates the BUGBOT.md rule: "Avoid className in public components (can be a private prop)". Multiple component interfaces in this file (TestHeaderProps, TestContentProps, etc.) also expose className.
| } | ||
| ) | ||
|
|
||
| TestSidebar.displayName = "TestSidebar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component logic in index.tsx instead of separate file (Bugbot Rules)
Low Severity
The component implementation is in index.tsx which violates the BUGBOT.md folder organization rule: "index.tsx the entrypoint of the components, it should only export, not having the logic" and "[COMPONENTNAME].tsx the component code". The types are also defined inline instead of in a separate types.ts file.
| export interface OneTestComponentProps { | ||
| children?: ReactNode | ||
| className?: string | ||
| variant?: "default" | "outlined" | "filled" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Union types used instead of const arrays (Bugbot Rules)
Low Severity
Props use inline union types like variant?: "default" | "outlined" | "filled" instead of the pattern specified in BUGBOT.md: using const arrays (export const variants = ['default', 'outlined', 'filled'] as const) with derived types. This applies to variant, padding, align, and position props.
Additional Locations (2)
| } | ||
| ) | ||
|
|
||
| TestSidebar.displayName = "TestSidebar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component missing required tests and storybook files (Bugbot Rules)
Medium Severity
The OneTestComponent is missing the required __tests__ and __stories__ folders. BUGBOT.md explicitly states that each component in components folder should have these: "__tests__ the components tests" and "__stories__ the storybook files". It also requires "Ensure the components have at least one story file" and lists "Missing test coverage for new components" as a common issue to check.
🔍 Visual review for your branch is published 🔍Here are the links to: |
Coverage Report for packages/react
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Description
Screenshots (if applicable)
[Link to Figma Design](Figma URL here)
Implementation details
Note
Adds a small new component and tightens repo automation.
OneTestComponentwith CSS and subcomponentsTestHeader,TestContent,TestFooter,TestSidebarundersrc/components/OneTestComponentformatand newlint-reacton staged React files;packages/reactlint/formatscripts accept optional path argspackages/react/BUGBOT.mdwith detailed guidelines for imports/exports, types, tests, styling, accessibility, and StorybookWritten by Cursor Bugbot for commit 764e647. This will update automatically on new commits. Configure here.