Skip to content

feat: add new banner component #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Nicotelo
Copy link

@Nicotelo Nicotelo commented Apr 15, 2025

Description

I'm adding a new banner component, that has two bottons: one meant for an upsell request, the other for redirection.
The banner will have 2 variants as well, depending on the usage of the feature

Screenshots (if applicable)

image

image

image

Options:
image

Figma Link

Link to Figma Design

Slack conversation: https://factorialteam.slack.com/archives/C06QT46115K/p1744712639367679

Type of Change

  • New experimental component
  • Promote component from experimental to stable
  • Maintenance / Bug Fix / Other

Experimental Component Checklist (if applicable)

  • Component added to experimental folder
  • Component is documented with basic stories
  • Component added to the
    Roadmap

@Nicotelo Nicotelo self-assigned this Apr 15, 2025
Copy link
Contributor

github-actions bot commented Apr 15, 2025

🔍 Visual review for your branch is published 🔍

Here are the links to:

@Nicotelo Nicotelo force-pushed the feat/add-banner-component-to-F1 branch 2 times, most recently from de7fe44 to f052d04 Compare April 15, 2025 14:57
@Nicotelo Nicotelo force-pushed the feat/add-banner-component-to-F1 branch from f052d04 to 187214e Compare April 15, 2025 15:02
@Nicotelo Nicotelo force-pushed the feat/add-banner-component-to-F1 branch from a65e0f9 to 468e381 Compare April 24, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant