Adds new method to versions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marachimeno
force-pushed
the
add-method-to-versions
branch
from
b8900d0 to
86ccb91
Compare
marachimeno
requested review from
gtrias,
atd,
andoni-zabala and
rebemartinezgr-factorial
atd
approved these changes
Oct 25, 2024
marachimeno
force-pushed
the
add-method-to-versions
branch
from
86ccb91 to
adb9c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚪 Why?
To be able to find the next version when given a specific version.
We found a use-case when trying to get the next version to generate the changelog.
In the changelog, when we want to generate the changelog for version 2025-01-01, for example, we would need to get the version changes from version 2024-10-01, so we made this method in order to make it dynamic so we do not have to manually change these methods and you can give the changelog generator any version to generate its changelog.
🔑 What?
Adds new method that, given a version, sorts the versions array by name and finds the next newer version.