Allow filter versions within a range #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marachimeno
force-pushed
the
version_in_a_range
branch
2 times, most recently
from
ac27ab6 to
be48993
Compare
rebemartinezgr-factorial
requested review from
marachimeno,
atd and
gtrias
and removed request for
marachimeno
| @@ -60,7 +60,7 @@ | |||
|
|
|||
| context 'when given a random value' do | |||
| it 'does not returns a version' do | |||
| expect(subject.find_next('2024-04-01')).to be_nil | |||
| expect { subject.find_next('2025-04-01') }.to raise_error(RuntimeError, 'Version \'2025-04-01\' not found') | |||
There was a problem hiding this comment.
it was returning nil because the value exists but was the last one (just like the context in line 55)
gtrias
reviewed
Oct 28, 2024
|
|
||
| context 'with only to' do | ||
| it 'filters versions by <= to' do | ||
| expect(subject.in_range(nil, '2024-09-20').count).to eq(3) |
There was a problem hiding this comment.
what if subject.in_range(nil, nil)?
There was a problem hiding this comment.
no filter is applied, so it returns the full list. do you want me to add this case in the spec?
There was a problem hiding this comment.
or would you expect a different behavior?
There was a problem hiding this comment.
I think it would be great to have this case covered since is the only one this test is missing and is one of the possible combinations :)
There was a problem hiding this comment.
Done!
gtrias
approved these changes
Oct 29, 2024
rebemartinezgr-factorial
force-pushed
the
version_in_a_range
branch
from
be48993 to
4654918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚪 Why?
For Public APi automatic testing epic we will need to read a list of Version within a range
🔑 What?
Allow filtering Versions by range using the name.
In Public API we are using dates as names i.e 2024-01-01, but it will work the same with SemVer because it will use alphabet comparison.