Make all relationships spec fields mandatory #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, we're deciding that if a given relationship doesn't have a `primary_key`, we fallback to `:id`. This can lead to unwanted behaviour and suprises from developers. Let's make it mandatory and ensure everything's present.
|
👏 |
atd
reviewed
Feb 10, 2025
| private | ||
|
|
||
| sig { void } | ||
| def validate_spec! |
There was a problem hiding this comment.
Shouldn't we have a class that defines all these, and raise these errors when instantiating it?
There was a problem hiding this comment.
I thought about it but it seemed overkill for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we're deciding that if a given relationship doesn't have a
primary_key, we fallback to:id. This can lead to unwanted behaviour and surprises from developers.Let's make it mandatory and ensure everything is present.