feat: esm & cjs output script for older projects that cannot afford to migrate to esm code.#722
Closed
j-d-carmichael wants to merge 6 commits intofacundoolano:mainfrom
j-d-carmichael:main
Closed
feat: esm & cjs output script for older projects that cannot afford to migrate to esm code.#722j-d-carmichael wants to merge 6 commits intofacundoolano:mainfrom j-d-carmichael:main
j-d-carmichael wants to merge 6 commits intofacundoolano:mainfrom
j-d-carmichael:main
Conversation
…o migrate to esm code
Author
|
The failing tests are not related to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESM is nice, but we run a lot of older projects where the client just does not have budget to warrant a full migration to esm code.
This small addition keeps this project running smoothly on esm and commonJS projects while letting the source code enjoy the benefits of esm... best of both worlds.