Skip to content

fix: Missing version, updated timestamp and recent changes#726

Merged
facundoolano merged 1 commit intofacundoolano:mainfrom
TheArmKing:main
Nov 10, 2025
Merged

fix: Missing version, updated timestamp and recent changes#726
facundoolano merged 1 commit intofacundoolano:mainfrom
TheArmKing:main

Conversation

@TheArmKing
Copy link
Copy Markdown
Contributor

Google Play has introduced a new data structure variant that affects metadata fields with indexes greater than 100 (as tested, for now) in the ds:5[1][2] array. The array may sometimes contain an object at the last index instead of individual indexed elements. This object contains the metadata with keys corresponding to the original index, plus one. (e.g., index 140 becomes key '141').

Fixes #725 by

  1. Modifying the extractor to use the fallbackPath if provided when the primary path returns null or undefined
  2. Adding fallbackPath for affected fields using ['ds:5', 1, 2, -1, '<index+1>', ...] notation

@ktecho
Copy link
Copy Markdown

ktecho commented Oct 28, 2025

I was trying to test this PR, but I think it doesn't work because of this problem.

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/user/dev/project/node_modules/google-play-scraper/dist/esm/index.js'

@ktecho
Copy link
Copy Markdown

ktecho commented Nov 5, 2025

@facundoolano Any chances to get this merged? Right now we cannot use this library for some apps because it fails.

@facundoolano
Copy link
Copy Markdown
Owner

facundoolano commented Nov 5, 2025

Were you able to test it? I reverted the issue you linked above.

Can I get confirmation from someone else this fixes the issue?

@ktecho
Copy link
Copy Markdown

ktecho commented Nov 5, 2025

Were you able to test it? I reverted the issue you linked above.

Can I get confirmation from someone else this fixes the issue?

I'll try, but I think @TheArmKing needs to rebase over master to take the revert?

@TheArmKing
Copy link
Copy Markdown
Contributor Author

Were you able to test it? I reverted the issue you linked above.
Can I get confirmation from someone else this fixes the issue?

I'll try, but I think @TheArmKing needs to rebase over master to take the revert?

Try now and let me know if it also works for you

@ktecho
Copy link
Copy Markdown

ktecho commented Nov 5, 2025

@TheArmKing Installing so it looks like this:

"google-play-scraper": "github:facundoolano/google-play-scraper#0280abf149b50682ca8f65c080302dc6d477c80b",

It works fine.

CC: @facundoolano

@fgraeff
Copy link
Copy Markdown

fgraeff commented Nov 10, 2025

Thanks for all your efforts, guys. Would be pretty cool to get this published in a new version @facundoolano. Have a good start to the week!

@ktecho
Copy link
Copy Markdown

ktecho commented Nov 10, 2025

Thanks for all your efforts, guys. Would be pretty cool to get this published in a new version @facundoolano. Have a good start to the week!

Just in case it takes a little time to release, you can get the fix like this:

npm i git+https://github.com/facundoolano/google-play-scraper#0280abf149b50682ca8f65c080302dc6d477c80b

@facundoolano facundoolano merged commit 376d823 into facundoolano:main Nov 10, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing version, updated timestamp and recent changes

4 participants