Added action plugin: Fetch entities by view #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fago
reviewed
Sep 15, 2016
|
|
||
| // Pull values out of contexts. | ||
| $contexts = array_map(function ($context) { | ||
| return $context->getContextData()->getValue(); |
There was a problem hiding this comment.
This can be nice done by implementing doExecute() instead.
|
|
||
| // Convert entities into entity ids. | ||
| $contexts = array_map(function ($context) { | ||
| return $context instanceof EntityInterface ? $context->id() : $context; |
There was a problem hiding this comment.
Interesting. Mabye we should add some support to allow ids to be required only.
| } | ||
| } | ||
|
|
||
| foreach (Views::getApplicableViews('rules') as $data) { |
There was a problem hiding this comment.
ouch, is there no method on the storage we can use?
| * rules = TRUE | ||
| * ) | ||
| */ | ||
| class Rules extends DisplayPluginBase { |
There was a problem hiding this comment.
Let's call this "Rules context provider" ? Theoretically this could be used by other modules also.
There was a problem hiding this comment.
That said, maybe does Ctools already have something in that direction we could use instead?
fago
requested changes
Sep 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a plugin that enables rules to fetch lists of entities from view. Similar to the action available in Rules bonus pack, but with typed contexts.
There is a views display plugin to be used for views that act as rules data sources. A plugin deriver will provide a rules action for every views display using this plugin, and add views contexts based on the views argument definitions.
I'm aware that there is no test coverage and probably some bugs. I would like to discuss feasibility of this approach before going any further.