Add matcher diagnistics and bug fixing #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated wrongly. Signed-off-by: drslebedev <[email protected]>
Signed-off-by: Alexander Krimm <[email protected]> Signed-off-by: drslebedev <[email protected]>
… mode." This reverts commit da99237. Signed-off-by: drslebedev <[email protected]>
…is not set Signed-off-by: drslebedev <[email protected]>
wirew0rm
approved these changes
Jun 26, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains the following changes:
Fix alignTagRelativeToLastMatched: return nullopt if _lastMatchedTag is not set
Revert "TimingMatcher takes into account dropped samples in streaming mode."
Picoscope: fix out of bounds read for picoscope data
Add diagnostics to TimeMatcher if index of last matched tag is calculated wrongly.