Fix received unexpected update warning.
#379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason was that the new longPollingIdx was compared against the last value already processed (playload->_update). The correct comparison must be with playload->_update + 1. Signed-off-by: drslebedev <[email protected]>
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
approved these changes
Jun 25, 2025
Member
wirew0rm
left a comment
wirew0rm
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason was that the new longPollingIdx was compared against the last value already processed (playload->_update). The correct comparison must be with playload->_update + 1.
for more info see comment: #371 (comment)