HTTP Server: make upgrade to http3 configurable #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
Member
Author
|
Also added a fix for the CI only caching the targets but not the compiled libraries which lead to CI failures. |
This by default disables the upgrade from http2 to http3, since there were some problems discovered that need to be fixed first. By only disabling the upgrade, the functionality is still there and can be tested, but does not break for unsuspecting users. Signed-off-by: Alexander Krimm <[email protected]>
Signed-off-by: Alexander Krimm <[email protected]>
wirew0rm
force-pushed
the
disableHttp3Upgrade
branch
from
198d27b to
1600e15
Compare
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
RalphSteinhagen
approved these changes
Jul 1, 2025
Member
RalphSteinhagen
left a comment
RalphSteinhagen
left a comment
There was a problem hiding this comment.
Looks good! 👍
Please add an issue to this PR (comment) detailing what needs to be fixed for the HTTP/3 upgrade support before merging this. Thanks in advance.
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
Member
Author
|
CI passed, just hit re-run once again to make sure that the CI-cache fix is working properly |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This by default disables the upgrade from http2 to http3, since there were some problems discovered that need to be fixed first.
By only disabling the upgrade, the functionality is still there and can be tested, but does not break for unsuspecting users.