RestClient: only single long poll request #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #371 introduced that long polling subscriptions would always fetch the next n (defaulted to 3) long polling indices to reduce the latency from roundtrip to single trip. For the happy path this works well, but in case of errors, the logic has to be improved to correctly handle responses arriving out of order. With the current logic this will re-fetch already received updates and lead to avalanches of requests, as these re-fetched requests will then also again arive out of order and refetch old data. Before increasing this value again, it should be ensured that the responses are either re-sorted on arrival or older updates correctly dropped without scheduling new requests. This change restores the behaviour from before the changes but keeps the logic in place so it can be reenabled after fixing the error-handling. Signed-off-by: Alexander Krimm <[email protected]>
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
had a problem deploying
to
configure coverage
GitHub Actions
Failure
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
wirew0rm
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
approved these changes
Jul 1, 2025
Contributor
drslebedev
left a comment
drslebedev
left a comment
There was a problem hiding this comment.
Looks good and can be merged as discussed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #371 introduced that long polling subscriptions would always fetch the next n (defaulted to 3) long polling indices to reduce the latency from roundtrip to single trip.
For the happy path this works well, but in case of errors, the logic has to be improved to correctly handle responses arriving out of order. With the current logic this will re-fetch already received updates and lead to avalanches of requests, as these re-fetched requests will then also again arive out of order and refetch old data. Before increasing this value again, it should be ensured that the responses are either re-sorted on arrival or older updates correctly dropped without scheduling new requests.
This change restores the behaviour from before the changes but keeps the logic in place so it can be reenabled after fixing the error-handling.