-
Notifications
You must be signed in to change notification settings - Fork 3
Switch to HTTP/{2,3} rest bridge #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9778dcc to
0f0eace
Compare
PR produced different images: |
0f0eace to
c1efcac
Compare
3fe03fc to
6440575
Compare
6440575 to
3091f9e
Compare
|
|
||
| std::unique_ptr<Dashboard> dashboard; | ||
| std::unique_ptr<Dashboard> dashboard; | ||
| std::shared_ptr<opencmw::client::RestClient> restClient = std::make_unique<opencmw::client::RestClient>(opencmw::client::VerifyServerCertificates(Digitizer::Settings::instance().checkCertificates)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this client would also be used in the RemoteSource blocks, so we have one connection only per remote peer.
|
@frankosterfeld I guess this is obsolete now since your other opencmw-cpp PR#371 has been merged. If you could confirm. Thanks in advance. |
Signed-off-by: Frank Osterfeld <[email protected]>
Signed-off-by: Frank Osterfeld <[email protected]>
Signed-off-by: Alexander Krimm <[email protected]>
only start a load test worker thread if the service is invoked with the coresponding cli flag, so it does not have to be run every time. Should eventually be split off into a separate tool. Signed-off-by: Alexander Krimm <[email protected]>
|
this was only cherry-picked onto a separate branch to verify that everything works properly before merging. I've rebased and changed the reference to the current opencmw-main commit and added a flag to not run the load worker by default on deployed instances, to make this ready to be merged. |
wirew0rm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, 3 things to follow up on in separate PRs:
- move load testing facilities into separate test binary
- make all UI requests transparent to the protocol so dashboards agnostic to the protocol instead of hardcoding RestClient
- Manage the RestClient instance:
- share it between Blocks in the Flowgraph and the UI
- remove the need to explicitly pass it around all the different components
- abstraction beteween mds and http(s)2/3 clients



























No description provided.