Skip to content

Conversation

@frankosterfeld
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 24, 2025

PR produced different images:

chart_0001.png

Got:

chart_0001.png

Expected:

chart_0001.png

Diff:

chart_0001.png

chart_fg_dipole_0001.png

Got:

chart_fg_dipole_0001.png

Expected:

chart_fg_dipole_0001.png

Diff:

chart_fg_dipole_0001.png

dashboardpage_layout_0001.png

Got:

dashboardpage_layout_0001.png

Expected:

dashboardpage_layout_0001.png

Diff:

dashboardpage_layout_0001.png

dashboardpage_layout_0002.png

Got:

dashboardpage_layout_0002.png

Expected:

dashboardpage_layout_0002.png

Diff:

dashboardpage_layout_0002.png

dashboardpage_layout_0003.png

Got:

dashboardpage_layout_0003.png

Expected:

dashboardpage_layout_0003.png

Diff:

dashboardpage_layout_0003.png

dashboardpage_layout_0004.png

Got:

dashboardpage_layout_0004.png

Expected:

dashboardpage_layout_0004.png

Diff:

dashboardpage_layout_0004.png

flowgraph_0003.png

Got:

flowgraph_0003.png

Expected:

flowgraph_0003.png

Diff:

flowgraph_0003.png

flowgraph_0004.png

Got:

flowgraph_0004.png

Expected:

flowgraph_0004.png

Diff:

flowgraph_0004.png

keypad_0001.png

Got:

keypad_0001.png

Expected:

keypad_0001.png

Diff:

keypad_0001.png

@frankosterfeld frankosterfeld force-pushed the frank/http2 branch 4 times, most recently from 3fe03fc to 6440575 Compare June 10, 2025 11:41
@frankosterfeld frankosterfeld changed the title Switch to HTTP/2 rest bridge Switch to HTTP/{2,3} rest bridge Jun 10, 2025

std::unique_ptr<Dashboard> dashboard;
std::unique_ptr<Dashboard> dashboard;
std::shared_ptr<opencmw::client::RestClient> restClient = std::make_unique<opencmw::client::RestClient>(opencmw::client::VerifyServerCertificates(Digitizer::Settings::instance().checkCertificates));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this client would also be used in the RemoteSource blocks, so we have one connection only per remote peer.

@RalphSteinhagen
Copy link
Member

@frankosterfeld I guess this is obsolete now since your other opencmw-cpp PR#371 has been merged.

If you could confirm. Thanks in advance.

frankosterfeld and others added 3 commits June 25, 2025 13:42
only start a load test worker thread if the service is invoked with the
coresponding cli flag, so it does not have to be run every time.
Should eventually be split off into a separate tool.

Signed-off-by: Alexander Krimm <[email protected]>
@wirew0rm
Copy link
Member

this was only cherry-picked onto a separate branch to verify that everything works properly before merging. I've rebased and changed the reference to the current opencmw-main commit and added a flag to not run the load worker by default on deployed instances, to make this ready to be merged.

@wirew0rm wirew0rm marked this pull request as ready for review June 25, 2025 13:22
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 3 things to follow up on in separate PRs:

  • move load testing facilities into separate test binary
  • make all UI requests transparent to the protocol so dashboards agnostic to the protocol instead of hardcoding RestClient
  • Manage the RestClient instance:
    • share it between Blocks in the Flowgraph and the UI
    • remove the need to explicitly pass it around all the different components
    • abstraction beteween mds and http(s)2/3 clients

@wirew0rm wirew0rm merged commit e752cd4 into main Jun 26, 2025
5 of 6 checks passed
@wirew0rm wirew0rm deleted the frank/http2 branch June 26, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants