added thread instrumentation and minor clean-up #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RalphSteinhagen
commented
Jul 10, 2025
RalphSteinhagen
commented
- removed/replaced opendigitizer::SineSource (busy-looping source, not blocking)
- added thread instrumentation
Member
Author
|
Needs GR4 to be bumped first. |
wirew0rm
reviewed
Jul 10, 2025
RalphSteinhagen
force-pushed
the
threadInstrumentation
branch
from
81cc0ad to
b7b0edd
Compare
... in favour of default GR4 gr::basic::ClockSource+gr::basic::SignalGenerator Signed-off-by: Ralph J. Steinhagen <[email protected]>
Signed-off-by: Ralph J. Steinhagen <[email protected]>
RalphSteinhagen
force-pushed
the
threadInstrumentation
branch
from
b7b0edd to
f59b4d7
Compare
wirew0rm
approved these changes
Aug 19, 2025
Member
wirew0rm
left a comment
wirew0rm
left a comment
There was a problem hiding this comment.
Looks good, one small question/issue, otherwise can be merged once the CI has passed.
| case gr::lifecycle::State::REQUESTED_PAUSE: | ||
| case gr::lifecycle::State::PAUSED: | ||
| _thread = std::thread([this]() { | ||
| gr::thread_pool::thread::setProcessName("UiScheduler #2 (paused)"); |
Member
There was a problem hiding this comment.
The numbering of the threads is not clear to me here. Is using the acutal thread-id instead of 2 missing here?
My interpretation is that this thread doesn't get it's own id because it is only a short lived helper thread to trigger the state change. Maybe it would be sufficient to change the #2 to (temp) or something like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.