Conversation
nugaon
left a comment
nugaon
left a comment
There was a problem hiding this comment.
For me it seems more like a bounty description than a FIP.
The document misses many parts that an Improvement Proposal should hold IMO, such as interface descriptions (for JS libraries and smart contracts), elaborating the required business logic, provide an exact solution for verification proofs, explaining how to use ZKP here...
reading this document I have more questions than answers that should be the other way around.
text/0014-soulbound-claims.md
Outdated
|
|
||
| # Summary | ||
|
|
||
| Soulbound tokens for identity claims allows for a better user and developer experience by using existing Web3 technologies based on NFT token standards. In this FIP we described our findings and recommendations for FDP identity claims. |
There was a problem hiding this comment.
Soulbound tokens are not NFTs, maybe non-transferable NFTs. one can get the wrong assumption about SBTs based on this IMO.
There was a problem hiding this comment.
the sample smart contract is a NFT without transfer solidity code. but terminology wise is not the same
| - As an issuer, I need to revoke claims | ||
| - As a holder, I need to read my issued claims | ||
| - As a holder, I need to share my issued claims with a verifier | ||
| - As a verifier, I need to ask a holder for verification |
There was a problem hiding this comment.
this process should support automatic steps without async, shouldn't it?
There was a problem hiding this comment.
Automatic steps you refer to delegated authority (EOA or smart contract address
) like did-ethr? I didn't described this here because it might be a separate topic
text/0014-soulbound-claims.md
Outdated
|
|
||
| ## Milestone 1 - Issuer | ||
|
|
||
| A Dapp with issuer capabilities can grant and revoke SBT to holders. The claims that the issuers creates are stored in Swarm, with the hash in the onchain SBT token. |
There was a problem hiding this comment.
| A Dapp with issuer capabilities can grant and revoke SBT to holders. The claims that the issuers creates are stored in Swarm, with the hash in the onchain SBT token. | |
| A Dapp with issuer capabilities can grant and revoke SBT to holders. The claims that the issuers create are stored on Swarm, with the hash of the on-chain SBT token. | |
text/0014-soulbound-claims.md
Outdated
| The implementation must be able to: | ||
|
|
||
| - Have SBT issuer smart contracts | ||
| - JavaScripts / Typescript library |
There was a problem hiding this comment.
I would link here the JS library for FDP contracts for reference: https://github.com/fairDataSociety/fdp-contracts/tree/master/js-library
There was a problem hiding this comment.
Regarding more details, you are very right, that's the reason I wanted to get your feedback. Indeed, it might be technical bounty, but I need to speced it out
3 participants
No description provided.