Conversation
nugaon
left a comment
nugaon
left a comment
There was a problem hiding this comment.
Nice work, +1 for the unit tests! : )
Please check my comments but overall it seems good.
| * @param accountData account data | ||
| * @param options upload options | ||
| */ | ||
| export async function uploadData( |
There was a problem hiding this comment.
I see you moved this function from file.ts to here, but can you elaborate for me please what is the role of the handler.ts in the service folders and according to what you distingish to put functions to the other main file like here the file.ts?
There was a problem hiding this comment.
file/file.ts, directory/directory.ts could be renamed to file/index.ts, directory/index.ts.
So, this renamed index.ts is an aggregation of all functions into functions that are available to the user. They validate user input and pass it to the method from handler.ts. handler.ts aggregates a function from utils.ts and other files.
IgorShadurin
force-pushed
the
feat/205-directory-uploading
branch
from
9f726c3 to
bedfb9b
Compare
2 participants
Close #205
Version for Node.js and browser. I failed to cover directory selection with real test. Perhaps it will be possible to cover with mocks.
Therefore, a page was created to manually test this functionality
test/manual/index.html.But the method will only work in the browser with fixes from this branch (
duplex: halffix): #151.