Hash the directory name of a package on install.

[costdev]

This PR ensures that the directory name of a FAIR package is renamed to slug-didhash on installation.

In particular, this deals with the installation of a package without knowing its DID in advance. For example, when uploading the ZIP file of a plugin or theme.

See #228

[afragen]

We already do this on direct install,

fair-plugin/inc/packages/namespace.php

Lines 646 to 676 in a6b8be8

	function rename_source_selection( string $source, string $remote_source, WP_Upgrader $upgrader ) {
	global $wp_filesystem;
	$did = wp_cache_get( Admin\ACTION_INSTALL_DID );
	if ( ! $did ) {
	return $source;
	}
	$metadata = fetch_package_metadata( $did );
	if ( is_wp_error( $metadata ) ) {
	return $metadata;
	}
	// Sanity check.
	if ( $upgrader->new_plugin_data['Name'] !== $metadata->name ) {
	return $source;
	}
	if ( str_contains( $source, get_did_hash( $did ) ) && basename( $source ) === $metadata->slug ) {
	return $source;
	}
	$new_source = trailingslashit( $remote_source ) . $metadata->slug . '-' . get_did_hash( $did );
	if ( trailingslashit( strtolower( $source ) ) !== trailingslashit( strtolower( $new_source ) ) ) {
	$wp_filesystem->move( $source, $new_source, true );
	}
	return trailingslashit( $new_source );
	}

[costdev]

That covers the "Direct Install" tab, whereas this covers the "Upload ZIP" or wp plugin install <URL|path/to/zip> install paths.

[Ipstenu]

@costdev Where are we here? Is this ready for 1.1?

[costdev]

@Ipstenu Just rebased the PR branch on main. It's ready for testing again.

🧪 Test this PR on Playground

[afragen]

I think https://github.com/afragen/fair-plugin/tree/rename-theme-on-download also solves issue with at least some code reuse.

[afragen]

costdev#8 to move from inc/updater to inc/packages