Add more data to get_package_data(), renamed from get_update_data()#286
Merged
afragen merged 10 commits intofairpm:mainfrom Oct 9, 2025
Merged
Add more data to get_package_data(), renamed from get_update_data()#286afragen merged 10 commits intofairpm:mainfrom
afragen merged 10 commits intofairpm:mainfrom
Conversation
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Contributor
Member
|
Looks like there's a breakage in the PR:
|
Contributor
Author
|
Can confirm but this is only in the plugin card. Need to look into plugin card and button creation. |
costdev
reviewed
Oct 4, 2025
costdev
reviewed
Oct 4, 2025
Signed-off-by: Andy Fragen <andy@thefragens.com>
Member
|
It's a bit weird, because when I did this, the "Update now" button appeared as expected. Not saying that's the right approach, but that data passes on to the determination of what the status is, or which button to show. |
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
costdev
reviewed
Oct 5, 2025
Signed-off-by: Andy Fragen <andy@thefragens.com>
costdev
approved these changes
Oct 6, 2025
Signed-off-by: Andy Fragen <andy@thefragens.com>
Ipstenu
approved these changes
Oct 9, 2025
afragen
added a commit
to costdev/fair-plugin
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Andy Fragen <andy@thefragens.com> Signed-off-by: Andy Fragen <andy@thefragens.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
get_update_data()toget_package_data().Add data elements needed for
plugins_apiorthemes_apifilter.