Skip to content

Fix plugin search, broke with escaping#309

Merged
costdev merged 8 commits intofairpm:mainfrom
afragen:fix-plugin-search
Oct 31, 2025
Merged

Fix plugin search, broke with escaping#309
costdev merged 8 commits intofairpm:mainfrom
afragen:fix-plugin-search

Conversation

@afragen
Copy link
Copy Markdown
Contributor

@afragen afragen commented Oct 30, 2025

Plugin search broke with escaping from #305

As replacement text is escaping we can ignore the other content as it's passed from core.

Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
@afragen afragen requested a review from costdev October 30, 2025 16:57
@github-actions
Copy link
Copy Markdown
Contributor

Signed-off-by: Andy Fragen <andy@thefragens.com>
thanks @costdev
@afragen
Copy link
Copy Markdown
Contributor Author

afragen commented Oct 30, 2025

Fixes #311

Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
@costdev
Copy link
Copy Markdown
Member

costdev commented Oct 31, 2025

Tested on nightly (6.9-beta2-61080-src) and 6.8, in both English (US) and Español

  • Search works as expected in all combinations of the versions/locales above. ✅
  • The plugin directory URL and text is replaced on a site using English (US), Español, and also when using Español and running a WordPress version that has no translation for the string (i.e. 6.9 beta has no translations yet, so it falls back to English). ✅

Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
@costdev costdev merged commit b015e89 into fairpm:main Oct 31, 2025
46 checks passed
@afragen afragen deleted the fix-plugin-search branch October 31, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants