Skip to content

translation POST request via user edit#418

Merged
cdils merged 2 commits intorelease_1.3.0from
fix/translation-post-request
Jan 12, 2026
Merged

translation POST request via user edit#418
cdils merged 2 commits intorelease_1.3.0from
fix/translation-post-request

Conversation

@norcross
Copy link
Member

@norcross norcross commented Jan 8, 2026

this PR adds api.wordpress.org/translations/ to the list of URLs that FAIR will send to the AC endpoints.

cdils and others added 2 commits January 7, 2026 16:20
Signed-off-by: Carrie Dils <carriedils@gmail.com>
Signed-off-by: Norcross <andrew.norcross@gmail.com>
@norcross norcross requested a review from costdev January 8, 2026 20:29
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

@norcross
Copy link
Member Author

norcross commented Jan 8, 2026

ref #42

@costdev costdev linked an issue Jan 8, 2026 that may be closed by this pull request
@costdev costdev added this to the 1.3 milestone Jan 8, 2026
@costdev
Copy link
Member

costdev commented Jan 8, 2026

Looks like the commit from @cdils which is on the main branch is here by mistake. It doesn't exist on the release_1.3.0 branch.

@cdils
Copy link
Contributor

cdils commented Jan 12, 2026

Looks like the commit from @cdils which is on the main branch is here by mistake. It doesn't exist on the release_1.3.0 branch.

@costdev Is there a way to remove it? It's showing up in other PRs as well...(E.g., #381)

@costdev
Copy link
Member

costdev commented Jan 12, 2026

It looks like PRs may have been based off the main branch rather than the 1.3.0 release branch. I'd, for example, probably just do something like this:

  1. Locally, rebase this PR's branch on the 1.3.0 release branch.
  2. Check the diff with the 1.3.0 release branch to make sure the only changes are those added in this PR.
  3. If all is well, force push (git push --force-with-lease) the changes to this PR's branch.

If all is not well, I'd:

  1. Branch off this PR's branch to a temp branch.
  2. Checkout this PR's branch and hard reset to the 1.3.0 release branch.
  3. Cherry-pick the commits from the temp branch to this PR's branch.
  4. Check the diff.
  5. If all is well, force push.

@cdils
Copy link
Contributor

cdils commented Jan 12, 2026

It looks like release.md was already merged into release_1.3.0 branch but this PR has a more recent version of that file. It'll get updated at one point or another, so I'll go ahead and merge this for now.

@cdils cdils merged commit 959315d into release_1.3.0 Jan 12, 2026
3 checks passed
@cdils cdils deleted the fix/translation-post-request branch January 12, 2026 19:50
@cdils
Copy link
Contributor

cdils commented Jan 22, 2026

Closes #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit user makes a POST call to WP translations

3 participants