Skip to content

fix: include plugin zip hash in release hash files (#213)#426

Merged
joedolson merged 2 commits intorelease_1.3.0from
fix/issue-213-plugin-hash
Feb 9, 2026
Merged

fix: include plugin zip hash in release hash files (#213)#426
joedolson merged 2 commits intorelease_1.3.0from
fix/issue-213-plugin-hash

Conversation

@shadyvb
Copy link
Contributor

@shadyvb shadyvb commented Jan 20, 2026

Issue

Fixes #213

Summary

Adds the plugin ZIP file hash to the release hash files (MD5SUMS, SHA1SUMS, SHA256SUMS, SHA384SUMS).

Problem

The plugin ZIP file created during the release workflow was not being included in the hash verification files. While the plugin hash was available as a GitHub release asset, users couldn't verify the plugin ZIP using the checksum files provided in the release.

Solution

Modified bin/bundle.sh to:

  • Auto-detect the plugin version from the plugin header
  • Auto-detect the repository name from GITHUB_REPOSITORY environment variable
  • Locate the plugin ZIP file in /tmp (where it's created by the release workflow)
  • Calculate and append its MD5, SHA1, SHA256, and SHA384 hashes to the respective hash files

Testing

The script now checks for the plugin ZIP file before attempting to hash it, and only processes it if it exists. The hashing follows the same pattern as the WordPress bundle zips.

Related

  • Plugin ZIP is created in the release workflow at line 25 of .github/workflows/releases.yml

Signed-off-by: Carrie Dils <carriedils@gmail.com>
@github-actions
Copy link
Contributor

Adds the plugin ZIP file hash to the release hash files (MD5SUMS, SHA1SUMS, SHA256SUMS, SHA384SUMS).

The plugin ZIP file created during the release workflow was not being included in the hash verification files. While the plugin hash was available as a GitHub release asset, users couldn't verify the plugin ZIP using the checksum files provided in the release.

Modified bin/bundle.sh to:
- Auto-detect the plugin version from the plugin header
- Auto-detect the repository name from GITHUB_REPOSITORY environment variable
- Locate the plugin ZIP file in /tmp (where it's created by the release workflow)
- Calculate and append its MD5, SHA1, SHA256, and SHA384 hashes to the respective hash files

Fixes #213

Signed-off-by: Shadi Sharaf <shady@sharaf.me>
@shadyvb shadyvb force-pushed the fix/issue-213-plugin-hash branch from ab1fc49 to 8c136b0 Compare January 20, 2026 13:10
@cdils cdils requested review from Ipstenu and chuckadams January 22, 2026 17:52
@cdils cdils changed the base branch from main to release_1.3.0 February 9, 2026 17:43
@cdils cdils added this to the 1.3 milestone Feb 9, 2026
@joedolson joedolson merged commit 503d677 into release_1.3.0 Feb 9, 2026
59 checks passed
@joedolson joedolson deleted the fix/issue-213-plugin-hash branch February 9, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing current plugin version hash in release hash files

4 participants