Fix syntax error in hash validation condition in bundle.sh#438
Closed
Ipstenu wants to merge 1 commit intorelease_1.3.0from
Closed
Fix syntax error in hash validation condition in bundle.sh#438Ipstenu wants to merge 1 commit intorelease_1.3.0from
Ipstenu wants to merge 1 commit intorelease_1.3.0from
Conversation
Signed-off-by: Mika Epstein ipstenu@halfelf.org Signed-off-by: Mika Ipstenu Epstein <ipstenu@halfelf.org>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On line 74 the condition is written as if
![[ $EXPECTED_HASH =~ ... ]]. There is no space between!and[[.In bash,
!immediately followed by[is treated as history expansion (![ = “last command starting with [”). In a non-interactive environment like Github Actions, that expansion fails or yields something that is not a valid command, so the shell reports “command not found."Signed-off-by: Mika Epstein ipstenu@halfelf.org