Skip to content

os: Upgrade python3-libcamera to fix issue on bookworm#551

Merged
sonnyp merged 1 commit into
masterfrom
fix-bookworm-zoom
Apr 2, 2025
Merged

os: Upgrade python3-libcamera to fix issue on bookworm#551
sonnyp merged 1 commit into
masterfrom
fix-bookworm-zoom

Conversation

@sonnyp
Copy link
Copy Markdown
Collaborator

@sonnyp sonnyp commented Apr 2, 2025

@sonnyp sonnyp requested a review from ethanjli April 2, 2025 13:31
Copy link
Copy Markdown
Collaborator

@ethanjli ethanjli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe https://github.com/PlanktoScope/PlanktoScope/pull/551/files#r2024924080 (which was a reply-comment I added before starting my review, oops!) is also a possible change suggestion.

Comment thread documentation/docs/community/contribute/tips-and-tricks.md
@chevreuill3000
Copy link
Copy Markdown
Contributor

chevreuill3000 commented Apr 2, 2025

This solved the issue on my end. I approve this work 🥇

As you can see the cute daphnia below which illustrate the fact that we do not subsample the stream anymore : here

Copy link
Copy Markdown
Contributor

@chevreuill3000 chevreuill3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job here

@sonnyp sonnyp force-pushed the fix-bookworm-zoom branch from 0209369 to 60dea6e Compare April 2, 2025 16:01
@ethanjli
Copy link
Copy Markdown
Collaborator

ethanjli commented Apr 2, 2025

Hmm, it looks like the bullseye builds fail when we version-pin. Here are the options I've thought of:

  1. follow the pattern set in https://github.com/PlanktoScope/PlanktoScope/blob/790290f28b8b47c08bfaa64fe1499ba75468c20e/software/distro/setup/base-os/platform-hardware/config.sh#L29-L30 for conditional execution in bullseye vs. bookworm.
  2. go back to having no version-pinning for python3-libcamera.
  3. merge os: Switch to bookworm, drop bullseye support #543 first (or rebase this PR on os: Switch to bookworm, drop bullseye support #543), merge this PR, and just accept that bullseye builds will fail until we implement option 1 or option 2 in a future PR.

I have a weak preference for option 1.

@sonnyp sonnyp force-pushed the fix-bookworm-zoom branch from 0816768 to ccca045 Compare April 2, 2025 17:49
@sonnyp
Copy link
Copy Markdown
Collaborator Author

sonnyp commented Apr 2, 2025

@ethanjli I will leave as is for simplicity and added a todo to revert this in PlanktoScope/device-backend#78

@sonnyp sonnyp merged commit 7b44a18 into master Apr 2, 2025
12 checks passed
@sonnyp sonnyp deleted the fix-bookworm-zoom branch April 2, 2025 18:04
@ethanjli
Copy link
Copy Markdown
Collaborator

ethanjli commented Apr 9, 2025

As discussed in the 2025-04-09 core team meeting, after finishing+merging #543 I will make a follow-up PR for version-pinning the picamera2 apt package - and the follow-up PR will not include any special bookworm-specific version guards for version-pinning the apt picamera2 package. The implication is that the OS setup scripts will no longer work on bullseye - see #543 (comment) for more context.

sonnyp added a commit that referenced this pull request May 12, 2025
Those workarounds where introduced in
#570 and
#551

They are not needed since
#601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants