Release #1092 — Task-96056: cross-project social login fallback - #1094
Open
vichugofsl wants to merge 1 commit into
Open
Release #1092 — Task-96056: cross-project social login fallback#1094vichugofsl wants to merge 1 commit into
vichugofsl wants to merge 1 commit into
Conversation
…le.is shared users).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Release of #1092 to
masterCherry-picks the single commit from #1092 (
2f38dc41) ontomasterfor production release. No other develop changes are included.What it does
Task-96056 — Hosanna (project 63452) shares the
dbp_usersdatabase with Bible.is (52341). When an existing Bible.is user signs into Hosanna with a social provider that sends no email (Facebook without email, or Apple ID on repeat sign-in), the project-scoped account lookup missed and there was no email to fall back on, leading to duplicate accounts or a blocked 401.This adds a cross-project fallback on the social identity itself (
provider_id+provider_user_id), parallel to the existing email fallback:linked_from_projectfield is returned on the login where the cross-project link happens.project_idis validated up front, returning a clean 404 instead of a 500 on an unknown project.Ref: #1092
NOTE 1
See the PR: #1092 to check the optional database change (index).