refactor: simplify sorting, pattern matching, and line iteration logic across distillers and pipeline modules

Author: fajarhide

src/distillers/jsts.rs

@@ -294,7 +294,7 @@ fn distill_tsc(input: &str) -> String {
 
     let mut sorted: Vec<(String, Vec<String>)> = by_file.into_iter().collect();
     // Sort by number of errors descending
-    sorted.sort_by(|a, b| b.1.len().cmp(&a.1.len()));
+    sorted.sort_by_key(|a| std::cmp::Reverse(a.1.len()));
 
     for (file, issues) in sorted.iter().take(5) {
         let count = issues.len();

src/pipeline/registry.rs

@@ -34,13 +34,11 @@ pub fn resolve_profile(command: &str) -> ToolProfile {
         let parts: Vec<&str> = cmd_lower.split_whitespace().collect();
         let sub = parts.get(1).copied().unwrap_or("");
         match sub {
-            "diff" | "show" | "whatchanged" => {
-                if !cmd_lower.contains("--stat") {
-                    return ToolProfile {
-                        segmentation: SegmentationMode::GitHunk,
-                        collapse: CollapseMode::Generic,
-                    };
-                }
+            "diff" | "show" | "whatchanged" if !cmd_lower.contains("--stat") => {
+                return ToolProfile {
+                    segmentation: SegmentationMode::GitHunk,
+                    collapse: CollapseMode::Generic,
+                };
             }
             _ => {}
         }

src/pipeline/scorer.rs

@@ -243,9 +243,8 @@ pub fn score_segments(
         }
         SegmentationMode::Line => {
             // Segment per line
-            let mut line_num = 1;
             let mut boost_counter = 0;
-            for line in input.lines() {
+            for (line_num, line) in (1..).zip(input.lines()) {
                 let mut tier = classify_line(line);
 
                 if tier == SignalTier::Critical {
@@ -272,7 +271,6 @@ pub fn score_segments(
                     context_score,
                     line_range: (line_num, line_num),
                 });
-                line_num += 1;
             }
         }
     }