Hermes Plugin for Omni #67
Replies: 4 comments 3 replies
Really appreciate you putting this together, this is honestly one of the more thoughtful integrations I’ve seen so far. You’re not just wrapping OMNI, you actually aligned with the native Hermes execution model. Using Also, The safety layer also stands out. Expanding to 22 dangerous env vars vs the usual ~13 baseline is a solid improvement. That said, there are two things we should fix before merging:
|
|
Thanks again for the detailed suggestions. They were very helpful. I've addressed the maintainer feedback in the Hermes OMNI plugin and pushed the changes here: Changes made:
Verification:
CI run: Appreciate the review. This made the plugin much more robust. |
|
Thanks! Happy to contribute as I'm also using Omni (and Hermes) extensively. |
Uh oh!
There was an error while loading. Please reload this page.
Put together a plugin for Hermes! https://github.com/Wysie/hermes-omni-plugin
All reactions