Skip to content

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jul 4, 2025

tsup got a rewrite in Rust using VoidZero rolldown named tsdown

this PR migrates from tsup to tsdown

performance for a build run on my windows PC is pnpm run build from 11s-12s to 7s


GitHub Actions CI

tsdown size is also a bit smaller than tsup

image

@Shinigami92 Shinigami92 added this to the vAnytime milestone Jul 4, 2025
@Shinigami92 Shinigami92 self-assigned this Jul 4, 2025
@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Jul 4, 2025
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit d676f11
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/687906703de01c0008737511
😎 Deploy Preview https://deploy-preview-3558.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (9e8a4e9) to head (d676f11).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3558   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2888     2888           
  Lines      221958   221958           
  Branches      931      930    -1     
=======================================
  Hits       221891   221891           
  Misses         67       67           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92 Shinigami92 marked this pull request as ready for review July 4, 2025 19:17
@Shinigami92 Shinigami92 requested a review from a team as a code owner July 4, 2025 19:17
@xDivisionByZerox
Copy link
Member

I'll need to verify that this build works as expected using the playground. Might take some time, as it doesn't have any priority for me right now.

@Shinigami92
Copy link
Member Author

I'll need to verify that this build works as expected using the playground. Might take some time, as it doesn't have any priority for me right now.

Sure, take your time. This is not a breaking change and can theoretically merged any time.

I use it already in unuse and here I checked it in the preview docs console.

@Shinigami92 Shinigami92 force-pushed the infra-migrate-to-tsdown branch from c5533ae to d676f11 Compare July 17, 2025 14:19
@Shinigami92 Shinigami92 requested a review from Copilot July 17, 2025 14:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the build toolchain from tsup to tsdown, a Rust-based rewrite of tsup using VoidZero rolldown. The migration aims to improve build performance (from 11-12s to 7s locally, 8s to 5s in CI) while maintaining equivalent functionality.

  • Replaces tsup configuration with tsdown configuration using simplified entry patterns
  • Updates package.json scripts and dependencies to use tsdown instead of tsup
  • Cleans up package.json exports structure by removing redundant nested "default" objects

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
tsup.config.ts Removes the existing tsup configuration file
tsdown.config.ts Adds new tsdown configuration with simplified glob patterns and publint integration
package.json Updates build scripts, dependencies, and cleans up exports structure
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: infra Changes to our infrastructure or project setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants