-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(location): Hungarian support for city name, full street address, continents, countries and directions (hu) #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
…ountries and directions
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
I see the test error. If I'm right, the test thinks the "Ü" is not a valid hungarian character? It is, how do I solve it? |
Nearly correct. The letter "Ü" is currently not listed in the list of "used" characters in the locale data. We use these lists to track all characters in a locale and look for "suspicious characters". You do not need to worry, since these lists are autogenerated through snapshot tests. All you need to do is run the test with the pnpm run test:update-snapshots |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3618 +/- ##
=========================================
Coverage 99.97% 99.97%
=========================================
Files 2894 2906 +12
Lines 222390 227012 +4622
Branches 932 931 -1
=========================================
+ Hits 222337 226959 +4622
Misses 53 53
🚀 New features to boost your workflow:
|
HU Location support for city name, full street address, continents, countries and directions.
includes: