Skip to content

Conversation

lupus78
Copy link

@lupus78 lupus78 commented Sep 27, 2025

HU Location support for city name, full street address, continents, countries and directions.

includes:

  • all countries and continents in hungarian
  • directions in hungarina
  • all hungarian settlement names as city name
  • most commong street names and suffixes
  • postal code pattern
  • building number pattern

@lupus78 lupus78 requested a review from a team as a code owner September 27, 2025 19:00
Copy link

netlify bot commented Sep 27, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 05af962
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/68d85dbef8233b0008b418d2
😎 Deploy Preview https://deploy-preview-3618.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Sep 27, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Sep 27, 2025
@lupus78
Copy link
Author

lupus78 commented Sep 27, 2025

I see the test error. If I'm right, the test thinks the "Ü" is not a valid hungarian character? It is, how do I solve it?

@xDivisionByZerox
Copy link
Member

I see the test error. If I'm right, the test thinks the "Ü" is not a valid hungarian character? It is, how do I solve it?

Nearly correct. The letter "Ü" is currently not listed in the list of "used" characters in the locale data. We use these lists to track all characters in a locale and look for "suspicious characters". You do not need to worry, since these lists are autogenerated through snapshot tests.

All you need to do is run the test with the -u flag to tell vitest to update the snapshots. You can do this by running the following command locally:

pnpm run test:update-snapshots

Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (dce234e) to head (05af962).

Additional details and impacted files
@@            Coverage Diff            @@
##             next    #3618     +/-   ##
=========================================
  Coverage   99.97%   99.97%             
=========================================
  Files        2894     2906     +12     
  Lines      222390   227012   +4622     
  Branches      932      931      -1     
=========================================
+ Hits       222337   226959   +4622     
  Misses         53       53             
Files with missing lines Coverage Δ
src/locales/hu/location/building_number.ts 100.00% <100.00%> (ø)
src/locales/hu/location/city_name.ts 100.00% <ø> (ø)
src/locales/hu/location/city_pattern.ts 100.00% <100.00%> (ø)
src/locales/hu/location/continent.ts 100.00% <100.00%> (ø)
src/locales/hu/location/country.ts 100.00% <100.00%> (ø)
src/locales/hu/location/direction.ts 100.00% <100.00%> (ø)
src/locales/hu/location/index.ts 100.00% <100.00%> (ø)
src/locales/hu/location/postcode.ts 100.00% <100.00%> (ø)
src/locales/hu/location/secondary_address.ts 100.00% <100.00%> (ø)
src/locales/hu/location/street_address.ts 100.00% <100.00%> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants