feat(locale): add ku_kmr_latin locale #3629
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
xDivisionByZerox
added
c: feature
xDivisionByZerox
added
m: color
…de and language identifiers
|
@xDivisionByZerox @matthewmayer now I’ve made all the changes you asked for. |
| weight: 1, | ||
| }, | ||
| { value: '{{person.firstName}} {{person.lastName}}', weight: 5 }, | ||
| { value: '{{person.lastName}} {{person.firstName}}', weight: 5 }, |
There was a problem hiding this comment.
Is this correct that names are sometimes written
LastName FirstName
And sometimes
FirstName LastName ?
There was a problem hiding this comment.
This is not a problem, but now It has been solved
| @@ -0,0 +1,22 @@ | |||
| export default [ | |||
| 'Bor', | |||
There was a problem hiding this comment.
Are colors usually capitalized? If not then please lowercase these.
There was a problem hiding this comment.
I'm sorry, now it has been solved.
|
please also re-run |
|
@matthewmayer Okay now everything is done |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3629 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 2906 2918 +12
Lines 222684 223030 +346
Branches 932 932
========================================
+ Hits 222631 222977 +346
Misses 53 53
🚀 New features to boost your workflow:
|
|
@matthewmayer @xDivisionByZerox Could you please check now and let me know if there are any issues? |
|
Nothing required on your end at this point. The one remaining test failure Is unrelated to this issue. |
There was a problem hiding this comment.
I'm a little confused here. Usually, only the locale that gets added should be in the diff here. But the entire table is marked as a diff. At first I thought it was due to the new line character being incorrect, but the formatter should have fixed that and didn't through on the check. So I'm a little confused.
@matthewmayer any idea what is going on here? 🤔
| @@ -0,0 +1,6 @@ | |||
| // src/locales/ku_lat/person/prefix.ts | |||
There was a problem hiding this comment.
I saw multiple of these comment. Do these indicate locale data that should be equivalent across the Kurdish locales in the Latin script?
There was a problem hiding this comment.
This one is only for my personal use. I usually add several comments like this across all my projects.
3 participants
No description provided.