Skip to content

Conversation

Nanlung
Copy link

@Nanlung Nanlung commented Oct 8, 2025

Summary
Adds Russian (ru) locale data for the book module so fakerRU.book.* no longer falls back to English.

What’s included

  • src/locales/ru/book/
    • author.ts: curated list of Russian(-language) authors
    • format.ts: ['Аудиокнига', 'Электронная книга', 'Твёрдый переплёт', 'Мягкая обложка']
    • genre.ts: Russian equivalents of the EN genres
    • publisher.ts: common Russian publishers
    • series.ts: popular series localized in Russian (e.g., «Песнь Льда и Пламени», «Гарри Поттер», «Дюна»)
    • title.ts: well-known Russian titles (e.g., «Война и мир», «Мастер и Маргарита», «Преступление и наказание»)
  • src/locales/ru/index.ts updated via generate:locales

Rationale and data sourcing

  • Followed Faker’s “Sourcing data for definitions” guidance: no copyrighted compilations.
  • Lists are curated from general knowledge and multiple sources; not copied from a single source.
  • Series/titles are provided in Russian where widely used; happy to adjust if the team prefers alternative translations or transliterations.

Validation

  • Ran:
    • pnpm run generate:locales
    • pnpm run preflight (format, lint, build, tests, ts-check)
  • Snapshots updated as part of preflight; no TypeScript or lint errors.

Notes for reviewers

  • Initial, focused set of entries to keep the change reviewable; can expand in follow-ups if desired.
  • Open to suggestions on author/publisher/title additions/removals and genre naming consistency.

Checklist

  • Locale data added under src/locales/ru/book
  • Indices regenerated
  • Preflight passed locally
  • No breaking changes

@Nanlung Nanlung requested a review from a team as a code owner October 8, 2025 16:23
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f1ef743
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/68e8e1c9fe08ef0007cf9438
😎 Deploy Preview https://deploy-preview-3631.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xDivisionByZerox
Copy link
Member

Please note that there is already a PR open that is trying to solve the same issue:

That one will be merged, you will probably run into merge conflicts. If you are willing to resolve the conflicts, your additions can still be added. Just wanted to give you a heads up.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: book Something is referring to the animal module labels Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: book Something is referring to the animal module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants