Skip to content

Conversation

@Pradeepg2445
Copy link
Contributor

This PR enhances the ta_IN locale with the following additions:

  • Added internet definitions (domain_suffix, free_email)
  • Added location data (city names, state list, postcode, street patterns)
  • Expanded person names (first_name, last_name, patterns)
  • Updated locale index to include new modules

All changes pass preflight checks and follow the existing locale structure.

@Pradeepg2445 Pradeepg2445 requested a review from a team as a code owner November 15, 2025 15:48
@netlify
Copy link

netlify bot commented Nov 15, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cf1231e
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/691bf84cab6c480008c6e0f3
😎 Deploy Preview https://deploy-preview-3659.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (24aa11f) to head (cf1231e).
⚠️ Report is 10 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3659      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2994     3037      +43     
  Lines      236305   237507    +1202     
  Branches      939      941       +2     
==========================================
+ Hits       236248   237448    +1200     
- Misses         57       59       +2     
Files with missing lines Coverage Δ
src/locales/ta_IN/color/human.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/color/index.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/commerce/department.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/commerce/index.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/company/adjective.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/company/descriptor.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/company/index.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/company/legal_entity_type.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/company/name_pattern.ts 100.00% <100.00%> (ø)
... and 34 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

generic: [
{ value: '{{person.last_name.generic}}', weight: 95 },
{
value: '{{person.last_name.generic}}-{{person.last_name.generic}}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are hyphenated surnames like this common in Tamil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Hyphenated surnames are not common in Tamil. I added the pattern only to follow the structure used in some other locales, but I can remove it to keep the data accurate for ta_IN.

I’ll update the PR and push the changes shortly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok you can make it 100% on the single last name pattern then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the review!
I’ve addressed all the pending feedback and pushed the updated changes.
Please let me know if anything else is needed from my side.

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module m: color Something is referring to the color module m: commerce Something is referring to the commerce module m: company Something is referring to the company module m: internet Something is referring to the internet module m: person Something is referring to the person module m: phone Something is referring to the phone module labels Dec 3, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature c: locale Permutes locale definitions m: color Something is referring to the color module m: commerce Something is referring to the commerce module m: company Something is referring to the company module m: internet Something is referring to the internet module m: location Something is referring to the location module m: person Something is referring to the person module m: phone Something is referring to the phone module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants