-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore(deps): update eslint (major) #3687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3687 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2995 2995
Lines 236324 236324
Branches 938 940 +2
=======================================
Hits 236267 236267
Misses 57 57
🚀 New features to boost your workflow:
|
0bc31a4 to
c75e625
Compare
c75e625 to
c80599b
Compare
|
I need to update some parts to align with the updated eslint preset rules:
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Shinigami92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish toSorted would be smarter and only necessary if the base array was a "mutable" array.
Right now it could just cost nano seconds of performance, but anyway, no production code was harmed 🤷
|
|
||
| const min = BigInt(options.min ?? 0); | ||
| const max = BigInt(options.max ?? min + BigInt(999999999999999)); | ||
| const max = BigInt(options.max ?? min + 999999999999999n); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might had these for legacy compatibility reasons.
Could you check if calling BigInt(0) is resulting in another kind of error as 0n in an old ecma version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell both the constructor and BigInt literals were both introduced at same time in ES2020 so it shouldn't make a difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that, however we are not using Intl global for some reason as well. Environments like React Native I think can have issues with that, and we don't have tests for that.
This PR contains the following updates:
1.4.1->2.0.054.7.0->61.5.060.0.0->62.0.0Release Notes
eslint/rewrite (@eslint/compat)
v2.0.0Compare Source
⚠ BREAKING CHANGES
Features
Dependencies
gajus/eslint-plugin-jsdoc (eslint-plugin-jsdoc)
v61.5.0Compare Source
Features
check-tag-names,require-template,check-template-names: maketypeParama non-preferred alias fortemplate(3cd7cbd)v61.4.2Compare Source
Bug Fixes
require-rejects: reflect proper tag name in error message (44b2631)v61.4.1Compare Source
Bug Fixes
require-rejects: do not treat synchronous throw as rejection; fixes #1603 (f776d63)v61.4.0Compare Source
Features
require-rejectsrule; fixes #755 (99c7fbd)v61.3.0Compare Source
Features
allowIndentedSectionsoption; fixes #541 (edaf615)v61.2.1Compare Source
Bug Fixes
require-param: ensure all structures with interfaces do not trigger withinterfaceExemptsParamsCheck: true(39a5b0a)tag-lines: avoid reformatting post-delimiter spacing; fixes #1593 (702b226)v61.2.0Compare Source
Features
sort-tags: addtagExceptionsto allow additional lines per tag; fixes #1594 (85a1ea1)v61.1.12Compare Source
Bug Fixes
no-undefined-types: treat param names as defined; fixes #1591 (b47779c)v61.1.11Compare Source
Bug Fixes
v61.1.10Compare Source
Bug Fixes
imports-as-dependencies: check for object-basedtypes(ortypings) (c9a22b6)v61.1.9Compare Source
Bug Fixes
v61.1.8Compare Source
Bug Fixes
no-undefined-types: consider module scope variables as defined; fixes #1581 (f938fdc)v61.1.7Compare Source
Bug Fixes
imports-as-dependencies: handle resolve.exports errors (0c4e5b6)v61.1.6Compare Source
Bug Fixes
imports-as-dependencies: check withinexportsfor types; fixes #1114 (c0e4e7c)v61.1.5Compare Source
Bug Fixes
v61.1.4Compare Source
Bug Fixes
to-valid-identifiershould be a dependency; fixes #1574 (89d37d0)v61.1.3Compare Source
Bug Fixes
prefer-import-tag: ensure import is a valid identifier; fixes #1572 (4349209)v61.1.2Compare Source
Bug Fixes
no-undefined-types: allow global prefixes; fixes #1566 (335450a)v61.1.1Compare Source
Bug Fixes
valid-types: reallowconsttype(75c8127)v61.1.0Compare Source
Features
ts-method-signature-style: add new rule (92bf39e)ts-no-empty-object-type: new rule to prevent empty objects (a19af97)ts-no-unnecessary-template-expression: create new rule to catch extra markup within template types (64082aa)ts-prefer-function-type: add new rule (cbda8aa)v61.0.1Compare Source
Bug Fixes
require-yields-*,require-throws-*: ensure alias of throws (exception) and of yields (yield) are checked; fixes #1559 (#1560) (38770c4)v61.0.0Compare Source
Features
type-formatting:keyValuePostColonSpacing,keyValuePostKeySpacing,keyValuePostOptionalSpacing,keyValuePostVariadicSpacingfor key-value pairs (and object fields) (ecf3a4a)type-formatting: addgenericAndTupleElementSpacingoption for tuples and generics (2735b6d)type-formatting: addparameterDefaultValueSpacingfor type parameter spacing (b8eeca8)type-formatting: add spacing for functions/classes and method quotes (a361dc9)type-formatting: changestringQuotesdefault todouble; fixes #1556 (0837647)BREAKING CHANGES
type-formatting: SetstringQuotesoption tosingleto restore old behaviorv60.8.3Compare Source
Bug Fixes
valid-types: ensure safe for class context (this keyword) (87464a6)valid-types: re-allow namepaths in name-definers like typedef in non-typescript mode; fixes #1557 (680cf1d)v60.8.2Compare Source
Bug Fixes
no-undefined-types: do not treat type parameters or their references as undefined; #1215 (#1553) (a5a0a3c)v60.8.1Compare Source
Bug Fixes
valid-types: parse distinctly for names vs. namepaths (#1552) (6efd9e9)v60.8.0Compare Source
Features
name-definingrole for likes oftypedefas distinct from likes ofparam(#1551) (e67e474)v60.7.1Compare Source
Bug Fixes
prefer-import-tag: handle other cases of comments before structures early in the document; fixes #1549 (622b17e)v60.7.0Compare Source
Bug Fixes
prefer-import-tag: handle inserting before early comment nodes; fixes #1549 (9e92718)Features
require-returns-check: addnoNativeTypesoption to assert async functions do not have native types as return types; fixes #1345 (13fe027)v60.6.0Compare Source
Features
escape-inline-tags: add new rule (#1547) (7a6b7db)v60.5.0Compare Source
Bug Fixes
no-undefined-types: avoid param and property tags from being treated as type-defining (f72ac1a)Features
check-tag-names: addinlineTagsoption with default inline tag checking (f0515be)require-template-description: add rule; fixes #1540 (90af18a)v60.4.1Compare Source
Bug Fixes
v60.4.0Compare Source
Bug Fixes
Features
flat/recommended-mixedconfig; fixes #1101 (68fad5b)v60.3.1Compare Source
Bug Fixes
getJsdocProcessPlugin: auto-escape*\/and entities (#1537) (74186a3), closes #710v60.3.0Compare Source
Features
no-undefined-types:checkUsedTypedefsoption; fixes #1165 (#1544) (001c4a9)v60.2.0Compare Source
Features
prefer-import-tags: add new rule; fixes #1314 (#1536) (376d583)v60.1.1Compare Source
Bug Fixes
reject-any-type,reject-function-type: prevent object replacement as withcheck-types; fixes #1538 (#1539) (0c4c654)v60.1.0Compare Source
Features
tag-lines:maxBlockLinesoption; fixes #1346 (#1532) (751428c)v60.0.0Compare Source
Bug Fixes
require-tags: change rule name to be consistent with other rules (#1535) (70c1b2e)BREAKING CHANGES
require-tags: Changesrequired-tagstorequire-tags.v59.1.0Compare Source
Features
required-tags: add new rule; fixes #1235 (47299db)v59.0.2Compare Source
Bug Fixes
v59.0.1Compare Source
Bug Fixes
require-yields-description,require-next-description: handle multiline descriptions; fixes #1528 (2544b12)check-examples(9a2763b)v59.0.0Compare Source
Bug Fixes
require-yields-check: removeexemptedByoption (7209fe0)Features
require-next-description,require-throws-decription,require-yields-description: add rules; fixes #1526 (214a5f2)BREAKING CHANGES
require-yields-check: RemovesexemptedByfromrequire-yields-check. Should not be needed.Also:
v58.1.1Compare Source
Bug Fixes
type-formatting: removepropertyIndentoption; fixes #1524 (#1525) (1cf93b5)v58.1.0Compare Source
Features
require-param: addinterfaceExemptsParamsCheckoption; fixes #1511 (#1521) (a3bb85e)v58.0.0Compare Source
Bug Fixes
Features
reject-any-typeandreject-function-typerules andextraRuleDefinitions.preferTypesoption (ae4e95d)BREAKING CHANGES
recommendedconfigsv57.2.1Compare Source
Bug Fixes
v57.2.0Compare Source
Features
check-types: deprecateunifyParentAndChildTypeChecksoption in favor of newunifyParentAndChildTypeCheckspreferredTypes[preferredType] setting (#1517) (224bbe6)v57.1.1Compare Source
Bug Fixes
v57.1.0Compare Source
Features
type-formatting: newobjectFieldSeparatorOptionalLinebreakoption (#1514) (6b20133)v57.0.10Compare Source
Bug Fixes
type-formatting: allow for $, _, and ZWNJ's without quoting (#1513) (dd0950b)v57.0.9Compare Source
Bug Fixes
type-formatting: do not strip quotes forobjectFieldQuotewhen not an ID; always allow unescaped digits (d53884a)v57.0.8Compare Source
Bug Fixes
v57.0.7Compare Source
Bug Fixes
v57.0.6Compare Source
Bug Fixes
examplesconfigs: disable@typescript-eslint/no-unsed-vars(#1507) (34e5910)v57.0.5Compare Source
Bug Fixes
index.configstype (#1505) (f019adf)v57.0.4Compare Source
Bug Fixes
jsdoc/examples/rulesandjsdoc/default-expressions/rulesconfigs: add @stylistic, @typescript-eslint, and eslint-plulgin-n equivalents to default disabled rules (#1504) (ab14982)v57.0.3Compare Source
Bug Fixes
valid-types: avoid reporting fornext(handled by own rule) (#1503) (76b8406)v57.0.2Compare Source
Bug Fixes
extraRuleDefinitions.forbidjsdoc function option: point default link to advanced page (#1502) (91f1c30)v57.0.1Compare Source
Bug Fixes
require-next-type,require-throws-type,require-yields-type: fix URL; fixes #1500 (#1501) (33a4529)v57.0.0Compare Source
Features
extraRuleDefinitions.forbidoption to jsdoc function (9f50083)require-next-type,require-throws-type,require-yields-type: adds new rules and adds to recommended and required configs; fixes #1461 (0645428)BREAKING CHANGES
require-next-type,require-throws-type,require-yields-type: It is unlikely to affect users but when using the jsdoc constructor with a recommended config , this commit removesthrowsandyieldsfrom the
structuredTagssettings recently added to the config output to require types for these tags in favor of the herein added equivalentrecommended rules. (
nextis still part ofstructuredTagsoutput, however, because this setting ensures the non-standard next tag is treatedas allowable without need for separate configuration.)
Also:
v56.1.2Compare Source
Bug Fixes
iterateJsdocexport: fix export (#1498) (be2b7ae)v56.1.1Compare Source
Bug Fixes
iterateJsdocexport: ensuredefaulthas type (#1497) (d5fb1d1)v56.1.0Compare Source
Features
type-formatting: addproperty,this,throws, andyieldstags (#1496) (8886628)v56.0.2Compare Source
Bug Fixes
getJsdocComment,iterateJsdoc: fix CJS type declarations (#1493) (5f00672)v56.0.1Compare Source
Bug Fixes
v56.0.0Compare Source
Features
BREAKING CHANGES
v55.4.0Compare Source
Features
type-formatting: addobjectFieldSeparatorTrailingPunctuationoption; fixes #1430 (5852fd9)type-formatting: check type and typedef tags and addtypeBracketSpacingoption (77e1691)type-formatting: enhance error detection and addunionSpacingoption; fixes #1143 (cc7f253)v55.3.0Compare Source
Features
type-formattingrule (81cb787)v55.2.0Compare Source
Features
v55.1.2Compare Source
Bug Fixes
v55.1.1Compare Source
Bug Fixes
v55.1.0Compare Source
Features
v55.0.5Compare Source
Bug Fixes
v55.0.4Compare Source
Bug Fixes
v55.0.3Compare Source
Bug Fixes
v55.0.2Compare Source
Bug Fixes
v55.0.1Compare Source
Bug Fixes
v55.0.0Compare Source
Features
BREAKING CHANGES
import {jsdoc} from 'eslint-plugin-jsdoc'; // A named import now is encouraged
export default [
...jsdoc({config: 'flat/recommended'}); // Now invoke the function to build the config
];
sindresorhus/eslint-plugin-unicorn (eslint-plugin-unicorn)
v62.0.0Compare Source
New rules
no-immediate-mutation(#2787)e1c7d2eno-useless-collection-argument(#2777)2d07c9aprefer-response-static-json(#2778)ffe5943Improvements
text-encoding-identifier-case: AddwithDashoption (#2780)9025386no-useless-undefined: Check oneundefinedat a time (#2792)27f7509prefer-single-call: Check optional chaining (#2788)8a132actext-encoding-identifier-case: Enforce'utf-8'inform[acceptCharset]andTextDecoder(#2785)46b3974prefer-node-protocol: Handle TypeScript import types (#2774)13a37a0no-array-for-each: IgnoreforEachfor Effect library (#2783)2ef6f83prefer-string-raw: Ignore more places that requires a string (#2776)43bc429prefer-string-raw: Add support for template literals (#2691)52723a2prefer-global-this: AddnavigationtowindowSpecificAPIs(#2770)0c93998prefer-code-point: Report cases whereString.fromCharCodeis not called directly (#2766)1d682a1no-useless-spread: Safely remove empty array and object (#2764)7aeababFixes
consistent-function-scoping: Fix inconsistent behavior (#2748)a546444v61.0.2Compare Source
throw-new-error: Fix false positive for Effect library (#2740)0ddf5eano-useless-undefined: IgnoreSet#delete(undefined)(#2739)99acd27prefer-includesandprefer-array-index-of: Prevent crash on Vue files (#2645)a1da518v61.0.1Compare Source
prefer-classlist-toggle: OmitElement#classList.contains()call when fixing (#2732)066f96bv61.0.0Compare Source
New rules
prefer-bigint-literals(#2722)1f4cb8aprefer-classlist-toggle(#2731)5f27ec2require-module-attributes(#2725)5f275e2no-array-sort(#2713)b70d1e8Improvements
unopinionatedconfig (#2715)c13d09b60b2ec5no-array-reduce: Report optional chaining and calling of.reduce()(#2721)caa1f8bprefer-type-error: Ignore error type check (#2729)d12fc01Fixes
prefer-includes: Fix compatibility with Vue SFC (#2704)540a4d4Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.