refactor(location): distinguish between street_name_part and street_name#3859
Open
ST-DDT wants to merge 2 commits into
Open
refactor(location): distinguish between street_name_part and street_name#3859ST-DDT wants to merge 2 commits into
ST-DDT wants to merge 2 commits into
Conversation
ST-DDT
added
p: 1-normal
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3859 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 905 905
Lines 3146 3146
Branches 564 564
=======================================
Hits 3112 3112
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
ST-DDT
commented
May 24, 2026
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors locale street name generation to distinguish between full street names (street_name) and composable street name components (street_name_part), updating affected locales’ street_pattern and locale exports accordingly.
Changes:
- Added
street_name_partto theLocationDefinitionschema and documented intended usage. - Updated multiple locales to use
street_name_partinstreet_patternand export the new dataset. - Adjusted locale-specific prefix/suffix usage (notably
es_MXreplacingstreet_suffixwith a properstreet_prefixlist).
Reviewed changes
Copilot reviewed 25 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/locales/uk/location/street_pattern.ts | Switches patterns to use street_name_part when composing street names. |
| src/locales/uk/location/street_name_part.ts | Adds Ukrainian street name parts dataset. |
| src/locales/uk/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/sv/location/street_pattern.ts | Switches Swedish street patterns to use street_name_part. |
| src/locales/sv/location/street_name_part.ts | Adds Swedish street name parts dataset. |
| src/locales/sv/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/ru/location/street_pattern.ts | Switches Russian street patterns to use street_name_part. |
| src/locales/ru/location/street_name_part.ts | Adds Russian street name parts dataset. |
| src/locales/ru/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/ro/location/street_pattern.ts | Switches Romanian street pattern to use street_name_part. |
| src/locales/ro/location/street_name_part.ts | Adds Romanian street name parts dataset. |
| src/locales/ro/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/nb_NO/location/street_pattern.ts | Switches Norwegian Bokmål patterns to use street_name_part. |
| src/locales/nb_NO/location/street_name_part.ts | Adds Norwegian Bokmål street name parts dataset. |
| src/locales/nb_NO/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/lv/location/street_pattern.ts | Switches Latvian street pattern to use street_name_part. |
| src/locales/lv/location/street_name_part.ts | Adds Latvian street name parts dataset. |
| src/locales/lv/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/ka_GE/location/street_pattern.ts | Switches Georgian street pattern to use street_name_part. |
| src/locales/ka_GE/location/street_name_part.ts | Adds Georgian street name parts dataset. |
| src/locales/ka_GE/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/hu/location/street_pattern.ts | Switches Hungarian street pattern to use street_name_part. |
| src/locales/hu/location/street_name_part.ts | Adds Hungarian street name parts dataset. |
| src/locales/hu/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/he/location/street_pattern.ts | Switches Hebrew street pattern to use street_name_part. |
| src/locales/he/location/street_name_part.ts | Adds Hebrew street name parts dataset. |
| src/locales/he/location/index.ts | Exports street_name_part instead of street_name. |
| src/locales/es_MX/location/street_suffix.ts | Removes street_suffix dataset (previously used as a prefix). |
| src/locales/es_MX/location/street_prefix.ts | Adds street_prefix dataset for proper prefix handling. |
| src/locales/es_MX/location/street_pattern.ts | Updates patterns to use street_prefix and street_name_part. |
| src/locales/es_MX/location/street_name_part.ts | Adds Mexican Spanish street name parts dataset. |
| src/locales/es_MX/location/index.ts | Switches exports to street_name_part and street_prefix. |
| src/locales/az/location/street_pattern.ts | Updates Azerbaijani street pattern to use street_name_part. |
| src/locales/az/location/street_name_part.ts | Adds Azerbaijani street name parts dataset. |
| src/locales/az/location/index.ts | Exports street_name_part instead of street_name. |
| src/definitions/location.ts | Adds street_name_part to the location definitions type + docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matthewmayer
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2062
Distinguish between
street_name_partandstreet_name.street_name_partmeant to be combined with street prefixes or suffixes.street_namefull existing street names.Deviations:
{{location.street_suffix}} {{location.street_name}}as it doesn't appear to be a thing.street_nameis used as is and with prefixes. The prefix is mostly omitted.