feat(helpers): resolve primitive fake property chains#3882
Open
puneetdixit200 wants to merge 1 commit into
Open
feat(helpers): resolve primitive fake property chains#3882puneetdixit200 wants to merge 1 commit into
puneetdixit200 wants to merge 1 commit into
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3882 +/- ##
==========================================
- Coverage 98.92% 98.89% -0.03%
==========================================
Files 908 908
Lines 3159 3165 +6
Branches 581 566 -15
==========================================
+ Hits 3125 3130 +5
- Misses 30 31 +1
Partials 4 4
🚀 New features to boost your workflow:
|
Member
|
Thanks for contributing to faker. ❤️ Please note: This may cause a merge conflict with #3857 So this may take far longer than usual to merge. |
Member
|
Please update the relevant jsdoc as well e.g. faker/src/modules/helpers/index.ts Line 1249 in 70994db |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3465
Verification
corepack pnpm exec vitest run test/modules/helpers-eval.spec.ts test/modules/helpers.spec.tscorepack pnpm exec prettier --check src/modules/helpers/eval.ts test/modules/helpers-eval.spec.ts test/modules/helpers.spec.tscorepack pnpm exec eslint src/modules/helpers/eval.ts test/modules/helpers-eval.spec.ts test/modules/helpers.spec.tsgit diff --checkcorepack pnpm exec vitest run test/scripts/shared/markdown.spec.tscorepack pnpm run ts-checkcorepack pnpm run test