feat(locale): add Welsh (cy) city name definitions#3884
Open
IestynGage wants to merge 1 commit into
Open
Conversation
I contemplated using the welsh city names, however they are only 7 and they overlap names with the counties. i.e. Abertawe, Caerdydd, Casnewydd and Wrecsam So as a alternative, I used `city_prefix` and `city_suffix` to make fake welsh sounding cities. Similiar to `en_GB`. I think a welsh speak would know they are fake, but they look like welsh cities names. I got the prefix & suffix by looking at welsh cities/towns/villages and breaking them up. Like how you can see a lot of welsh towns named `Aber`-something.
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3884 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 910 910
Lines 3161 3161
Branches 581 581
=======================================
Hits 3127 3127
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
matthewmayer
approved these changes
Jun 6, 2026
ST-DDT
approved these changes
Jun 6, 2026
ST-DDT
added
p: 1-normal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I contemplated using real welsh city names, however they are only 7 and they overlap names with the counties.
i.e. Abertawe, Caerdydd, Casnewydd and Wrecsam, so for the address method it could return the same city + county.
So as a alternative, I used
city_prefixandcity_suffixto make fake welsh sounding cities. Similiar toen_GB.I think a welsh speak would know they are fake, but they look like welsh cities names.
I got the prefix & suffix by looking at welsh cities/towns/villages and breaking them up. Like how you can see a lot of welsh towns named
Aber-something. (Aber meaning 'river mouth' or where the river meets the sea, so Aberystwyth = where the river ystwyth meets the sea).