Skip to content

Replace via.placeholder.com with placehold.co #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

runephilosof-abtion
Copy link

@runephilosof-abtion runephilosof-abtion commented Mar 5, 2025

Fixes #3055

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

@runephilosof-abtion
Copy link
Author

runephilosof-abtion commented Mar 5, 2025

Oops. I did not check the differences in the APIs.
placehold.co does not support just specifying a background color.
If you specify one, you must specify the other.

What color did via.placeholder.com use when only specifying the background color?
I assumed the defaults were black on white and that specifying one would only change that one. So I retained that functionality.

Will push the new commit soon ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken links for placeholdit
1 participant