Skip to content

Add mountains to de-CH locale #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

codez
Copy link
Contributor

@codez codez commented Mar 28, 2025

Motivation / Background

This Pull Request has been created because the mountains generator only includes Asian and American mountains. Hereby we add a list of mountains in the Swiss alps specifically for the de-CH locale.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

@@ -4866,6 +4866,274 @@ de-CH:
- Parsec
- Kiloparsec
- Megaparsec
mountain:
name:
- Albis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind narrowing the list down to maybe 10-15 options?
We don't need to provide every possible option, and this would also impact locale loading time.

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! But let's narrow this list down to fewer options.
Do you mind rebasing?

@codez codez force-pushed the de-ch-mountains branch from 26c7295 to 79a658e Compare May 9, 2025 14:06
@codez
Copy link
Contributor Author

codez commented May 9, 2025

@thdaraujo There you go. I guess it's really difficult to find a good balance between enough variation, a vast amount of topics and acceptable loading times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants