Skip to content

perf: offer stream_logs for BoundFunction#160

Merged
chamini2 merged 11 commits intomainfrom
matteo/no-stream-logs-run
Jan 14, 2025
Merged

perf: offer stream_logs for BoundFunction#160
chamini2 merged 11 commits intomainfrom
matteo/no-stream-logs-run

Conversation

@chamini2
Copy link
Member

@chamini2 chamini2 commented Oct 21, 2024

We spend a lot of time serializing / deserializing messages that we ignore. So sending an option to turn them off.

@chamini2 chamini2 requested review from efiop and isidentical October 21, 2024 20:31
@chamini2 chamini2 force-pushed the matteo/no-stream-logs-run branch from 77f8cac to ba97ef5 Compare October 21, 2024 21:56
@isidentical
Copy link
Collaborator

please don't merge without my review 👀

@chamini2 chamini2 force-pushed the matteo/no-stream-logs-run branch from a2fc4ec to 58296a9 Compare January 9, 2025 18:35
@chamini2 chamini2 force-pushed the matteo/no-stream-logs-run branch from 58296a9 to ddd5edd Compare January 13, 2025 16:29
@chamini2 chamini2 force-pushed the matteo/no-stream-logs-run branch from f0193bb to 3cd467c Compare January 13, 2025 16:45
@chamini2 chamini2 requested a review from isidentical January 13, 2025 21:11
@chamini2 chamini2 changed the title perf: offer stream_logs for TaskMetadata and handle it for Run too perf: offer stream_logs for BouindFunction Jan 13, 2025
@chamini2 chamini2 changed the title perf: offer stream_logs for BouindFunction perf: offer stream_logs for BoundFunction Jan 13, 2025
@chamini2 chamini2 merged commit 64144e9 into main Jan 14, 2025
6 checks passed
@chamini2 chamini2 deleted the matteo/no-stream-logs-run branch January 14, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants