feat: Associate request ids with log lines by using json logs and contextvars#185
Merged
feat: Associate request ids with log lines by using json logs and contextvars#185
Conversation
chamini2
reviewed
Dec 14, 2025
| "message": message, | ||
| **self.log_labels, | ||
| **self.extra_labels, | ||
| **line_labels, |
sanjayprabhu
force-pushed
the
sanjay/json_logs
branch
from
8327c8e to
69cea01
Compare
Contributor
|
pls rebase, i've fixed the macos tests. |
sanjayprabhu
force-pushed
the
sanjay/json_logs
branch
from
69cea01 to
2c4f675
Compare
sanjayprabhu
force-pushed
the
sanjay/json_logs
branch
from
29f9191 to
1281680
Compare
hanchchch
force-pushed
the
sanjay/json_logs
branch
from
6010ba3 to
fbc9035
Compare
hanchchch
force-pushed
the
sanjay/json_logs
branch
from
5155afe to
fbc9035
Compare
hanchchch
force-pushed
the
sanjay/json_logs
branch
from
f349af2 to
58eba4c
Compare
chamini2
approved these changes
Feb 3, 2026
sanjayprabhu
commented
Feb 3, 2026
Contributor
Author
sanjayprabhu
left a comment
sanjayprabhu
left a comment
There was a problem hiding this comment.
Nice, good idea. We don't need the ellipsis anymore with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For multiplexed apps, we can't associate raw logs/stdout lines with request ids. So, wrap stdout/stderr/log fd with a Json wrapper that writes the line as well as request specific context from contextvars at the agent level. The server then converts it back from json and merges the log level metadata into other metadata before writing it's own json log line.
Fal app PR here fal-ai/fal#740