fix(chart): skip falcoctl config volume when artifacts are disabled

[immanuwell]

/kind bug
/kind chart-release
/area chart

What this PR does / why we need it:

Tiny chart papercut. When both falcoctl artifact containers are disabled, the falcoctl ConfigMap is skipped but the pod still references falcoctl-config-volume. Kubernetes then tries to mount a ConfigMap that does not exist, so yeah, pod startup can fail.

Repro:

helm template rendered-resources chart/falco \
  --set falcoctl.artifact.install.enabled=false \
  --set falcoctl.artifact.follow.enabled=false | \
  rg "falcoctl-config-volume|falcoctl.yaml|rendered-resources-falco-falcoctl"

Before this fix, the pod rendered falcoctl-config-volume pointing to rendered-resources-falco-falcoctl, while that ConfigMap was not rendered. After this fix, no stale falcoctl ConfigMap refs are rendered when both artifact containers are off.

Which issue(s) this PR fixes:

None found.

Special notes for your reviewer:

make chart-check passes locally.

Does this PR introduce a user-facing change?:

fix(chart): do not render the falcoctl config volume when falcoctl artifact install and follow are disabled

[poiana]

Welcome @immanuwell! It looks like this is your first PR to falcosecurity/falco 🎉

[poiana]

LGTM label has been added.

Details

Git tree hash: 4bf022086180d6c20d1b3431df6c4ceab313e7db

[leogr]

LGTM.

/hold we are releasing Falco 0.44 and we are under freeze currently. TBD if we want to merge this now or immediately after the release

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: immanuwell, leogr, sgaist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [leogr,sgaist]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment