fix(chart): correct inverted priority level mappings in Grafana dashboard#3932
Conversation
…oard Falco encodes rule priorities numerically as 0=Emergency (highest) through 7=Debug (lowest). The dashboard's renameByRegex transforms had this exactly backwards, mapping 0→"default", 1→"debug", …, 7→"alert", 8→"emergency", causing alert severity labels to be displayed in the wrong order in all pie-chart and time-series panels. Fix all four occurrences of the mapping block so they follow Falco's actual encoding: 0→emergency, 1→alert, 2→critical, 3→error, 4→warning, 5→notice, 6→informational, 7→debug The spurious "8"→"emergency" entry (no such Falco priority) is removed. Fixes falcosecurity#3926 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Goutham Annem <annem.usedu@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Goutham-Annem The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kunalworldwide
left a comment
There was a problem hiding this comment.
The mapping fix is clearly needed — the previous dashboard was showing inverted severity labels because the renameByRegex transforms assumed the opposite numeric encoding. Removing the spurious 8 -> emergency entry is also correct since Falco has no priority 8.
A chart-only change like this is easy to miss in code review, but the impact on operators using the Grafana dashboard is significant. Would it be worth adding a small unit test that loads the dashboard JSON and asserts the rename mappings? That would prevent a future regression if someone edits the dashboard via the Grafana UI and re-exports it.
LGTM otherwise.
|
Hi, just checking in — CI is passing and the branch is clean. Happy to make any adjustments if needed! |
|
Friendly bump — any feedback on this one? Happy to make changes if needed. |
|
Gentle ping on this one — CI is passing. Happy to address any feedback. |
|
Friendly ping — CI is passing and this PR is ready for review. Would appreciate a look when you have a moment! |
Summary
The Grafana dashboard's
renameByRegextransforms had Falco's numeric priority levels exactly backwards.Falco encodes priorities as (see
userspace/engine/falco_common.h):The dashboard was mapping them in reverse order (0→"default", 1→"debug", …, 7→"alert", 8→"emergency"), which caused the wrong severity labels to appear on all pie-chart and time-series panels.
This PR fixes all four occurrences of the mapping block to match Falco's actual numeric encoding, and removes the spurious
"8"→"emergency"entry (Falco has no priority 8).Fixes #3926
Test plan