wip: feat(userspace/falco): clarify rules validation errors#3947
Open
AkashKumar7902 wants to merge 1 commit into
Open
wip: feat(userspace/falco): clarify rules validation errors#3947AkashKumar7902 wants to merge 1 commit into
AkashKumar7902 wants to merge 1 commit into
Conversation
Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AkashKumar7902 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Welcome @AkashKumar7902! It looks like this is your first PR to falcosecurity/falco 🎉 |
AkashKumar7902
marked this pull request as ready for review
July 19, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
/area tests
What this PR does / why we need it:
When
--validatereceives a top-level YAML mapping such asfalco.yaml, rules validation currently reports only a structural error. This change adds an actionable hint explaining that--validateaccepts rules files and that--dry-runvalidates a Falco configuration together with its configured rules.The hint is added in the
validate_rules_filesapplication action, so normal rule loading and embedded engine callers are unchanged. JSON stdout remains machine-parseable; the hint stays in the fatal error summary written to stderr.Which issue(s) this PR fixes:
Related to #3725
Special notes for your reviewer:
This is a draft because #3725 is assigned to @leogr; I would appreciate confirmation that the diagnostic wording and app-layer placement match the intended scope.
Validation:
clang-format18.1.8 andcmake-format0.6.13 hooksfalco_unit_testsActionValidateRulesFilesregressions--dry-runhint to stdout and stderrDoes this PR introduce a user-facing change?: