wip: test(userspace/libsinsp/test): reduce converter tests memory impact#2703
Draft
ekoops wants to merge 2 commits intofalcosecurity:masterfrom
Draft
wip: test(userspace/libsinsp/test): reduce converter tests memory impact#2703ekoops wants to merge 2 commits intofalcosecurity:masterfrom
ekoops wants to merge 2 commits intofalcosecurity:masterfrom
Conversation
Add `<filename>:<linenumber> |` prefix to `assert_event_presence()` assertions and exception messages, and make the new signature ergonomic by introducing a new `ASSERT_EVENT_PRESENCE()` macro. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
poiana
added
kind/test
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2703 +/- ##
==========================================
+ Coverage 76.91% 76.94% +0.02%
==========================================
Files 294 294
Lines 30862 30897 +35
Branches 4689 4693 +4
==========================================
+ Hits 23739 23774 +35
Misses 7123 7123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ekoops
force-pushed
the
ekoops/scap-file-tests
branch
2 times, most recently
from
f8f8b93 to
52483fa
Compare
ekoops
force-pushed
the
ekoops/scap-file-tests
branch
from
52483fa to
726abd8
Compare
ekoops
changed the title
ekoops
changed the title
ekoops
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/milestone 0.23.0
Does this PR introduce a user-facing change?: