Repository navigation
fix: find comments after a backtick in a JS regex literal - #133
Merged
Merged
Conversation
Copy the fixed scripts/check-comment-quality.mjs and its tests from fallow-rs/fallow (fallow-rs/fallow#4230). The check treated every backtick in a JavaScript file as the start of a template literal. A backtick inside a regex literal, a quoted string, or a comment opened a template that never closed, and the check skipped every comment after that line. The opener scan now skips these constructs. Signed-off-by: Bart Waardenburg <bart@waardenburg.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Copy the fixed
scripts/check-comment-quality.mjsand its tests from fallow-rs/fallow (fallow-rs/fallow#4230).Why
The check treated every backtick in a JavaScript file as the start of a template literal. A backtick inside a regex literal, a quoted string, or a comment opened a template that never closed. The check then skipped every comment after that line, so a history comment passed. The check failed open, so it never blocked a valid comment.
Test plan
node --test scripts/check-comment-quality.test.mjsnode scripts/check-comment-quality.mjs --all